sunchao commented on code in PR #5603:
URL: https://github.com/apache/datafusion-comet/pull/5603#discussion_r3985441747
##########
spark/src/main/scala/org/apache/comet/serde/structs.scala:
##########
@@ -31,20 +31,8 @@ import
org.apache.comet.CometSparkSessionExtensions.withFallbackReason
import org.apache.comet.DataTypeSupport
import org.apache.comet.serde.QueryPlanSerde.{exprToProtoInternal,
serializeDataType}
-object CometCreateNamedStruct extends CometExpressionSerde[CreateNamedStruct] {
-
- private val duplicateNamesReason =
- "`CreateNamedStruct` with duplicate field names is not supported"
-
- override def getUnsupportedReasons(): Seq[String] = Seq(duplicateNamesReason)
-
- override def getSupportLevel(expr: CreateNamedStruct): SupportLevel = {
- if (expr.names.length != expr.names.distinct.length) {
- Unsupported(Some(duplicateNamesReason))
- } else {
- Compatible()
- }
- }
+object CometCreateNamedStruct
+ extends CometExpressionSerde[CreateNamedStruct] {
Review Comment:
[P2] Fix the declaration formatting to unblock CI
Could you put this declaration on one line and rerun CI?
```scala
object CometCreateNamedStruct extends
CometExpressionSerde[CreateNamedStruct] {
```
I independently ran the root-reactor Spotless check on the exact base and
head. Base `8e684685` passes, while head `714aa8d9` fails solely on this
declaration. The Spark 4.1 build and both Celeborn compatibility jobs report
the same formatting error before compilation. The runtime checks I ran with
style checks skipped passed, but the normal build remains blocked here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
