adriangb commented on PR #25161: URL: https://github.com/apache/datafusion/pull/25161#issuecomment-5626576123
Correction to my own review comment above, item 3: `cargo-semver-checks` is **not** red on this PR. The `Check semver` job reports `SUCCESS`. I have removed the matching sentence from the description, which claimed the tool flags the deprecation and the factory arity change. Items 1, 2, 4 and 5 in that comment stand. Item 4 in particular — `datafusion/functions/src/datetime/mod.rs` still describes `from_unixtime` as converting "an integer to RFC3339 timestamp format string", the same wrong claim that commit `bda12f1` corrected in the `user_doc` block. I am fixing that in a follow-up commit here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
