github-actions[bot] commented on PR #25161: URL: https://github.com/apache/datafusion/pull/25161#issuecomment-5622714204
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-functions v55.0.0 (current) Built [ 32.044s] (current) Parsing datafusion-functions v55.0.0 (current) Parsed [ 0.082s] (current) Building datafusion-functions v55.0.0 (baseline) Built [ 31.745s] (baseline) Parsing datafusion-functions v55.0.0 (baseline) Parsed [ 0.081s] (baseline) Checking datafusion-functions v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.521s] 223 checks: 221 pass, 2 fail, 0 warn, 31 skip --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_parameter_count_changed.ron Failed in: datafusion_functions::datetime::from_unixtime now takes 1 parameters instead of 0, in /home/runner/work/datafusion/datafusion/datafusion/functions/src/datetime/mod.rs:55 --- failure type_method_marked_deprecated: type method #[deprecated] added --- Description: A type method is now #[deprecated]. Downstream crates will get a compiler warning when using this method. ref: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/type_method_marked_deprecated.ron Failed in: method datafusion_functions::datetime::from_unixtime::FromUnixtimeFunc::new in /home/runner/work/datafusion/datafusion/datafusion/functions/src/datetime/from_unixtime.rs:89 Summary semver requires new major version: 1 major and 1 minor checks failed Finished [ 65.910s] datafusion-functions Building datafusion-sql v55.0.0 (current) Built [ 42.718s] (current) Parsing datafusion-sql v55.0.0 (current) Parsed [ 0.032s] (current) Building datafusion-sql v55.0.0 (baseline) Built [ 42.917s] (baseline) Parsing datafusion-sql v55.0.0 (baseline) Parsed [ 0.032s] (baseline) Checking datafusion-sql v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.244s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 87.036s] datafusion-sql Building datafusion-sqllogictest v55.0.0 (current) Built [ 101.557s] (current) Parsing datafusion-sqllogictest v55.0.0 (current) Parsed [ 0.022s] (current) Building datafusion-sqllogictest v55.0.0 (baseline) Built [ 101.610s] (baseline) Parsing datafusion-sqllogictest v55.0.0 (baseline) Parsed [ 0.023s] (baseline) Checking datafusion-sqllogictest v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.093s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 206.353s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
