lxc512157407 commented on PR #24821: URL: https://github.com/apache/datafusion/pull/24821#issuecomment-5618604536
CI failures on the last run were all addressed: 1. **clippy `uninlined_format_args`** — test code in `filter.rs` used positional format args; fixed in ad773bcb1. 2. **sqllogictest mismatch in `predicates.slt:985`** (`explain select x from t where x NOT IN (1,2,3,4) OR x NOT IN (5,6,7,8)`) — this is the optimization working as intended: the `FilterExec: x IS NOT NULL` node is now **eliminated** because the new null_count check proves the conjunct is always true (the source column is non-nullable after the existing `Filter: t.x IS NOT NULL`). The three failing jobs (cargo test, extended_tests, sqlite slt) all failed on this single query; the expectation was updated in 913eac03b. 3. Also merged latest main (35e68e268) to pick up current baselines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
