lxc512157407 commented on PR #24821: URL: https://github.com/apache/datafusion/pull/24821#issuecomment-5601094958
Thanks @kumarUjjawal! Addressed both comments: 1. **Index-based stats lookup**: Changed from to for looking up . Added a regression test () that creates a schema with duplicate field names where field 0 has zero nulls but same-named field 1 has NULLs — verifies only the former's conjunct gets dropped. 2. **True pass-through on lit(true)**: Added the early-return in : when the predicate is and there's no projection/fetch, we return the input stream directly (no FilterExecStream, no mask eval, no coalescer). Added regression test that verifies the same batch passes through unchanged. Updated PR body to include `closes #24942`. Clippy and fmt both pass. Let me know if you'd like any adjustments! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
