alamb commented on code in PR #12083:
URL: https://github.com/apache/datafusion/pull/12083#discussion_r1723920989
##########
datafusion/common/src/hash_utils.rs:
##########
@@ -386,9 +386,6 @@ pub fn create_row_hashes<'a>(
random_state: &RandomState,
hashes_buffer: &'a mut Vec<u64>,
) -> Result<&'a mut Vec<u64>> {
- for hash in hashes_buffer.iter_mut() {
Review Comment:
NM -- Now I see that @Dandandan and @yjshen are saying in
https://github.com/apache/datafusion/pull/12083/files#r1723796994 we should
just delete (all) this code 💯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
