alamb commented on code in PR #12083:
URL: https://github.com/apache/datafusion/pull/12083#discussion_r1723919592
##########
datafusion/common/src/hash_utils.rs:
##########
@@ -386,9 +386,6 @@ pub fn create_row_hashes<'a>(
random_state: &RandomState,
hashes_buffer: &'a mut Vec<u64>,
) -> Result<&'a mut Vec<u64>> {
- for hash in hashes_buffer.iter_mut() {
Review Comment:
I think the reason this code sets the values to zero is so that some code
paths can reuse the same buffer for the hashes -- otherwise there may be left
over hashes from previous batches.
Maybe we could make something more clever that remembered when the buffer
was being reused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
