kosiew commented on code in PR #25032: URL: https://github.com/apache/datafusion/pull/25032#discussion_r3964355506
########## benchmarks/sql_benchmarks/predicate_eval/predicate_eval.suite: ########## @@ -1,4 +1,4 @@ -description = "Conjunctive filter evaluation micro-benchmarks covering predicate cost, selectivity, cardinality, width, scale, correlation, and drift" +description = "Conjunctive filter evaluation micro-benchmarks covering predicate cost, selectivity, cardinality, width, scale, correlation, drift, and nullable predicates" Review Comment: Optional follow-up: it would be useful to add an automated smoke test that runs a few representative new load shapes through the real `predicate_eval` template and validates the results. The current runner tests use synthetic suites, so they would not catch drift between the load, query, and result paths here. I would avoid using the suite defaults as a supposedly lightweight smoke test, since they generate 1M rows. Lowering `PRED_ROWS` would also make the checked-in count fixtures invalid, so a CI test would probably need its own small fixtures or dedicated configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
