github-actions[bot] commented on PR #24936: URL: https://github.com/apache/datafusion/pull/24936#issuecomment-5594325998
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-functions-nested v55.0.0 (current) Built [ 37.942s] (current) Parsing datafusion-functions-nested v55.0.0 (current) Parsed [ 0.039s] (current) Building datafusion-functions-nested v55.0.0 (baseline) Built [ 37.779s] (baseline) Parsing datafusion-functions-nested v55.0.0 (baseline) Parsed [ 0.039s] (baseline) Checking datafusion-functions-nested v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.204s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 77.324s] datafusion-functions-nested Building datafusion-spark v55.0.0 (current) Built [ 46.012s] (current) Parsing datafusion-spark v55.0.0 (current) Parsed [ 0.063s] (current) Building datafusion-spark v55.0.0 (baseline) Built [ 46.774s] (baseline) Parsing datafusion-spark v55.0.0 (baseline) Parsed [ 0.067s] (baseline) Checking datafusion-spark v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.312s] 223 checks: 219 pass, 4 fail, 0 warn, 31 skip --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_missing.ron Failed in: function datafusion_spark::function::string::expr_fn::encode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/bdac685faf8cb3ff969ee653f85b8b76f046e61d/datafusion/spark/src/function/string/mod.rs:97 function datafusion_spark::expr_fn::encode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/bdac685faf8cb3ff969ee653f85b8b76f046e61d/datafusion/spark/src/function/string/mod.rs:97 function datafusion_spark::function::string::encode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/bdac685faf8cb3ff969ee653f85b8b76f046e61d/datafusion/spark/src/function/string/mod.rs:50 --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_parameter_count_changed.ron Failed in: datafusion_spark::function::math::modulus::spark_pmod now takes 2 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/spark/src/function/math/modulus.rs:107 --- failure module_missing: pub module removed or renamed --- Description: A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/module_missing.ron Failed in: mod datafusion_spark::function::string::encode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/bdac685faf8cb3ff969ee653f85b8b76f046e61d/datafusion/spark/src/function/string/encode.rs:18 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_missing.ron Failed in: struct datafusion_spark::function::string::encode::SparkEncode, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/bdac685faf8cb3ff969ee653f85b8b76f046e61d/datafusion/spark/src/function/string/encode.rs:59 Summary semver requires new major version: 4 major and 0 minor checks failed Finished [ 94.429s] datafusion-spark Building datafusion-sqllogictest v55.0.0 (current) Built [ 105.094s] (current) Parsing datafusion-sqllogictest v55.0.0 (current) Parsed [ 0.022s] (current) Building datafusion-sqllogictest v55.0.0 (baseline) Built [ 105.887s] (baseline) Parsing datafusion-sqllogictest v55.0.0 (baseline) Parsed [ 0.024s] (baseline) Checking datafusion-sqllogictest v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.095s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 213.822s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
