alamb commented on PR #11943: URL: https://github.com/apache/datafusion/pull/11943#issuecomment-2299211653
I ran the benchmarks on my test machine and I see similar results Overall things get significantly better but a few get slower (e.g. `Q37`) but I suspect we can figure out how to resolve those regressions Nice work @Rachelint <details><summary>Details</summary> <p> ``` -------------------- Benchmark clickbench_1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main_base ┃ sketch-blocked-aggr-state-manag… ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 0.67ms │ 0.65ms │ no change │ │ QQuery 1 │ 68.94ms │ 69.74ms │ no change │ │ QQuery 2 │ 121.34ms │ 124.61ms │ no change │ │ QQuery 3 │ 129.89ms │ 129.66ms │ no change │ │ QQuery 4 │ 936.36ms │ 942.38ms │ no change │ │ QQuery 5 │ 1026.98ms │ 1043.44ms │ no change │ │ QQuery 6 │ 64.75ms │ 64.06ms │ no change │ │ QQuery 7 │ 70.95ms │ 71.93ms │ no change │ │ QQuery 8 │ 1420.64ms │ 1449.10ms │ no change │ │ QQuery 9 │ 1326.29ms │ 1312.99ms │ no change │ │ QQuery 10 │ 450.67ms │ 452.53ms │ no change │ │ QQuery 11 │ 489.22ms │ 490.92ms │ no change │ │ QQuery 12 │ 1098.01ms │ 1150.82ms │ no change │ │ QQuery 13 │ 2093.09ms │ 2132.07ms │ no change │ │ QQuery 14 │ 1509.44ms │ 1407.02ms │ +1.07x faster │ │ QQuery 15 │ 1059.78ms │ 1083.76ms │ no change │ │ QQuery 16 │ 2791.68ms │ 2514.43ms │ +1.11x faster │ │ QQuery 17 │ 2723.41ms │ 2334.14ms │ +1.17x faster │ │ QQuery 18 │ 5524.82ms │ 4618.96ms │ +1.20x faster │ │ QQuery 19 │ 120.94ms │ 120.93ms │ no change │ │ QQuery 20 │ 1666.50ms │ 1646.72ms │ no change │ │ QQuery 21 │ 1980.75ms │ 2004.30ms │ no change │ │ QQuery 22 │ 4447.17ms │ 4814.76ms │ 1.08x slower │ │ QQuery 23 │ 10832.04ms │ 11183.51ms │ no change │ │ QQuery 24 │ 724.92ms │ 770.28ms │ 1.06x slower │ │ QQuery 25 │ 628.52ms │ 676.36ms │ 1.08x slower │ │ QQuery 26 │ 790.67ms │ 810.57ms │ no change │ │ QQuery 27 │ 2450.10ms │ 2456.62ms │ no change │ │ QQuery 28 │ 15010.69ms │ 15157.30ms │ no change │ │ QQuery 29 │ 555.38ms │ 567.09ms │ no change │ │ QQuery 30 │ 1235.77ms │ 1269.06ms │ no change │ │ QQuery 31 │ 1329.18ms │ 1259.29ms │ +1.06x faster │ │ QQuery 32 │ 4442.15ms │ 3562.04ms │ +1.25x faster │ │ QQuery 33 │ 4857.95ms │ 4926.93ms │ no change │ │ QQuery 34 │ 4855.86ms │ 4844.55ms │ no change │ │ QQuery 35 │ 1777.21ms │ 1676.27ms │ +1.06x faster │ │ QQuery 36 │ 329.33ms │ 325.24ms │ no change │ │ QQuery 37 │ 206.27ms │ 222.18ms │ 1.08x slower │ │ QQuery 38 │ 187.72ms │ 193.16ms │ no change │ │ QQuery 39 │ 953.90ms │ 805.04ms │ +1.18x faster │ │ QQuery 40 │ 85.84ms │ 85.80ms │ no change │ │ QQuery 41 │ 75.64ms │ 77.68ms │ no change │ │ QQuery 42 │ 93.59ms │ 94.78ms │ no change │ └──────────────┴────────────┴──────────────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (main_base) │ 82545.02ms │ │ Total Time (sketch-blocked-aggr-state-management) │ 80943.69ms │ │ Average Time (main_base) │ 1919.65ms │ │ Average Time (sketch-blocked-aggr-state-management) │ 1882.41ms │ │ Queries Faster │ 8 │ │ Queries Slower │ 4 │ │ Queries with No Change │ 31 │ └─────────────────────────────────────────────────────┴────────────┘ -------------------- Benchmark clickbench_extended.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Query ┃ main_base ┃ sketch-blocked-aggr-state-management ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ QQuery 0 │ 2560.03ms │ 2572.44ms │ no change │ │ QQuery 1 │ 815.54ms │ 787.44ms │ no change │ │ QQuery 2 │ 1608.52ms │ 1564.49ms │ no change │ └──────────────┴───────────┴──────────────────────────────────────┴───────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (main_base) │ 4984.08ms │ │ Total Time (sketch-blocked-aggr-state-management) │ 4924.38ms │ │ Average Time (main_base) │ 1661.36ms │ │ Average Time (sketch-blocked-aggr-state-management) │ 1641.46ms │ │ Queries Faster │ 0 │ │ Queries Slower │ 0 │ │ Queries with No Change │ 3 │ └─────────────────────────────────────────────────────┴───────────┘ -------------------- Benchmark clickbench_partitioned.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main_base ┃ sketch-blocked-aggr-state-manag… ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 2.24ms │ 2.20ms │ no change │ │ QQuery 1 │ 36.56ms │ 36.84ms │ no change │ │ QQuery 2 │ 94.43ms │ 92.39ms │ no change │ │ QQuery 3 │ 100.36ms │ 97.89ms │ no change │ │ QQuery 4 │ 900.11ms │ 888.40ms │ no change │ │ QQuery 5 │ 927.01ms │ 949.77ms │ no change │ │ QQuery 6 │ 32.76ms │ 33.28ms │ no change │ │ QQuery 7 │ 38.37ms │ 38.96ms │ no change │ │ QQuery 8 │ 1357.93ms │ 1383.54ms │ no change │ │ QQuery 9 │ 1275.61ms │ 1304.53ms │ no change │ │ QQuery 10 │ 355.18ms │ 344.31ms │ no change │ │ QQuery 11 │ 381.17ms │ 389.12ms │ no change │ │ QQuery 12 │ 1023.05ms │ 1023.38ms │ no change │ │ QQuery 13 │ 1777.28ms │ 1802.44ms │ no change │ │ QQuery 14 │ 1402.28ms │ 1300.19ms │ +1.08x faster │ │ QQuery 15 │ 1017.98ms │ 1013.41ms │ no change │ │ QQuery 16 │ 2720.14ms │ 2402.69ms │ +1.13x faster │ │ QQuery 17 │ 2666.07ms │ 2270.11ms │ +1.17x faster │ │ QQuery 18 │ 5556.13ms │ 4609.12ms │ +1.21x faster │ │ QQuery 19 │ 91.77ms │ 90.43ms │ no change │ │ QQuery 20 │ 1701.59ms │ 1733.05ms │ no change │ │ QQuery 21 │ 1923.91ms │ 1950.76ms │ no change │ │ QQuery 22 │ 4527.11ms │ 4901.07ms │ 1.08x slower │ │ QQuery 23 │ 9657.16ms │ 9727.87ms │ no change │ │ QQuery 24 │ 560.04ms │ 560.20ms │ no change │ │ QQuery 25 │ 480.05ms │ 476.33ms │ no change │ │ QQuery 26 │ 632.81ms │ 622.17ms │ no change │ │ QQuery 27 │ 2387.49ms │ 2439.88ms │ no change │ │ QQuery 28 │ 14453.61ms │ 14570.84ms │ no change │ │ QQuery 29 │ 518.62ms │ 518.83ms │ no change │ │ QQuery 30 │ 1102.69ms │ 1082.36ms │ no change │ │ QQuery 31 │ 1164.73ms │ 1044.84ms │ +1.11x faster │ │ QQuery 32 │ 4423.73ms │ 3532.24ms │ +1.25x faster │ │ QQuery 33 │ 4733.47ms │ 4781.66ms │ no change │ │ QQuery 34 │ 4773.42ms │ 4767.46ms │ no change │ │ QQuery 35 │ 1692.69ms │ 1587.80ms │ +1.07x faster │ │ QQuery 36 │ 265.73ms │ 280.72ms │ 1.06x slower │ │ QQuery 37 │ 123.95ms │ 130.43ms │ 1.05x slower │ │ QQuery 38 │ 143.98ms │ 141.72ms │ no change │ │ QQuery 39 │ 931.49ms │ 747.43ms │ +1.25x faster │ │ QQuery 40 │ 58.42ms │ 56.86ms │ no change │ │ QQuery 41 │ 49.07ms │ 48.09ms │ no change │ │ QQuery 42 │ 64.88ms │ 63.64ms │ no change │ └──────────────┴────────────┴──────────────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (main_base) │ 78127.05ms │ │ Total Time (sketch-blocked-aggr-state-management) │ 75839.22ms │ │ Average Time (main_base) │ 1816.91ms │ │ Average Time (sketch-blocked-aggr-state-management) │ 1763.70ms │ │ Queries Faster │ 8 │ │ Queries Slower │ 3 │ │ Queries with No Change │ 32 │ └─────────────────────────────────────────────────────┴────────────┘ ``` </p> </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
