emilk opened a new pull request, #25081:
URL: https://github.com/apache/datafusion/pull/25081
## Which issue does this PR close?
- Part of #18467.
## Rationale for this change
Part 3 of 3, split out of #24848. Stacked on parts 1 and 2, so review those
first:
- PR1LINK
- PR2LINK
Turn on more `clippy::pedantic` lints from the opt-out list in `Cargo.toml`.
## What changes are included in this PR?
| Lint
| Sites | Fix
|
|
-----------------------------------------------------------------------------------------
| ----: |
----------------------------------------------------------------------- |
|
[`if_not_else`](https://rust-lang.github.io/rust-clippy/master/index.html#if_not_else)
| 141 | positive condition first, so the reader does not have to negate
mentally |
Mostly `cargo clippy --fix`. Comments that described the negated branch
moved to
the branch they describe, and thirteen sites in `datafusion-sql` were done by
hand because one suggestion there did not type-check, which made rustfix roll
back the whole crate.
Let me know if you disagree and I'll revert it.
## What is the testing strategy for this PR?
Clippy is clean both with `--all-features` and with default features. The
changes are mechanical, so no new tests.
## Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
