divyankshah commented on PR #5235: URL: https://github.com/apache/datafusion-comet/pull/5235#issuecomment-5590122373
Rebased onto main again to clear a fresh conflict, so this is mergeable once more. The conflict was a small one in `array_funcs/mod.rs`. #5614 added `mod sequence;` right next to the `mod nested_float_normalize;` line added here, so the two additions landed on adjacent lines of the same list. Both are kept, in alphabetical order, along with the `pub use sequence::spark_sequence;` re-export from main. Nothing else needed changing, and none of the expression code in this PR was affected. Re-verified after the rebase: - `cargo test -p datafusion-comet-spark-expr`: 723 passed, 0 failed - `cargo clippy -p datafusion-comet-spark-expr --lib --all-targets -- -D warnings`: clean - `cargo fmt -p datafusion-comet-spark-expr -- --check`: clean For what it is worth, the previous push had a full green CI run, including the array SQL file tests, so the rebase is the only thing that has changed since then. @andygrove, @peterxcli, whenever either of you has a spare moment, this one is ready for another look. No rush at all, I know review bandwidth is tight. If it would be easier to review as a single squashed commit, or if you would prefer the `normalize_nan.rs` cleanup folded in first, just say the word and I will sort it out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
