alamb commented on code in PR #25007:
URL: https://github.com/apache/datafusion/pull/25007#discussion_r3960551874
##########
datafusion/common/src/config.rs:
##########
@@ -964,13 +964,14 @@ config_namespace! {
/// the new schema verification step.
pub skip_physical_aggregate_schema_check: bool, default = false
- /// Temporary switch for aggregate stream implementations that are
being
- /// migrated from `GroupedHashAggregateStream`.
+ /// Temporary switch for the aggregate stream implementations that were
+ /// split out of `GroupedHashAggregateStream`.
///
- /// When set to true, DataFusion tries the migrated implementations
when
- /// their preconditions are satisfied. When set to false, grouped
- /// aggregation falls back to `GroupedHashAggregateStream`. This option
- /// will be removed after the migration is finished.
+ /// The split is complete, so the default `true` plans every grouped
Review Comment:
I recommend focusing this more on the end user behavior -- something like
```rust
/// When set to false, falls back to the pre 55.0.0 aggregation
code.
/// The fallback is intended as a workaround in case of bugs and
/// will be deleted after the 56.0.0 release together with this
option.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
