viirya commented on issue #5768: URL: https://github.com/apache/datafusion-comet/issues/5768#issuecomment-5581379179
Opened #5769. One correction to this issue while doing it: there is a third site, `get_array_struct_fields`, and its guard is not merely different but wrong. It skipped the union when the parent and child null **counts** matched, which is not the same question — equal counts can still sit at different rows, and then a null of the parent's was dropped. So the PR carries a behaviour fix alongside the refactor, with a test for that shape. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
