kosiew commented on code in PR #24866: URL: https://github.com/apache/datafusion/pull/24866#discussion_r3951104642
########## datafusion/common/src/config.rs: ########## Review Comment: Could we make `ParquetEncryptionKeyRetriever::retrieve_key` return a key even when the metadata is empty in this regression test? Right now the retriever rejects empty metadata, which means the implementation before this change would also return an error, so the test does not quite exercise the reported failure mode. If the retriever always succeeds, we can verify that the conversion still fails specifically because `uses_key_retriever()` detects it, rather than because retrieving the footer key fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
