rluvaton commented on PR #24017: URL: https://github.com/apache/datafusion/pull/24017#issuecomment-5557947512
> I think this PR is pretty clean now, and the quality is maintained by good practice. However, if we don't rely on explicit states, I think it's more likely to get poisoned in the future (e.g. adding mysterious local flags for new features, making it confusing again). @2010YOUY01 I will merge this and you can make a pr that will add explicit states while keeping it clean. the only thing I don't like about this is that I have hash table and spill context that I immediately `take()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
