xudong963 commented on code in PR #24887:
URL: https://github.com/apache/datafusion/pull/24887#discussion_r3942910151
##########
datafusion/physical-expr/src/aggregate.rs:
##########
@@ -933,24 +933,44 @@ impl AggregateFunctionExpr {
/// For aggregates that do not support calculation in reverse,
/// returns None (which is the default value).
pub fn reverse_expr(&self) -> Option<AggregateFunctionExpr> {
+ self.reverse_expr_inner(false)
+ }
+
+ /// Same as [`Self::reverse_expr`], but the output `name` is always carried
+ /// over unchanged.
+ ///
+ /// Window execs derive their output schema from `WindowExpr::field()`,
which
+ /// for aggregate-backed window expressions is this expression's `name`. If
+ /// reversal renamed it, the rebuilt window exec would expose a differently
+ /// named column while parent plan nodes still reference the old one. This
+ /// mirrors `WindowUDFExpr::reverse_expr`, which preserves its name for the
+ /// same reason. `AggregateExec`, by contrast, pins its schema at
+ /// construction, so it can use [`Self::reverse_expr`] and let the name
+ /// reflect the function actually being evaluated.
+ pub fn reverse_expr_preserving_name(&self) ->
Option<AggregateFunctionExpr> {
Review Comment:
Here exposes `reverse_expr_preserving_name`() publicly, but its only current
caller is the crate-internal window helper. how about making it pub(crate)
unless there is a concrete downstream use case.
Public APIs become long-term compatibility commitments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
