kumarUjjawal commented on code in PR #24836:
URL: https://github.com/apache/datafusion/pull/24836#discussion_r3940629867
##########
datafusion/pruning/benches/string_in_list_pruning.rs:
##########
@@ -101,20 +105,20 @@ struct IntervalStatistics {
}
impl IntervalStatistics {
- fn new(domain_size: usize) -> Self {
- let min =
StringViewArray::from_iter_values((0..CONTAINERS).map(|index| {
+ fn new(domain_size: usize, container_count: usize) -> Self {
Review Comment:
The new container-count axis also changes the sampled domain distribution.
For a 1,024-value domain, 16 containers exercise only the first 8 values, 256
exercise the first 128, while 4,096 exercise the entire domain twice. That
changes binary-search positions, branch behavior, and string-comparison work
along with the container count, so the resulting crossover cannot be attributed
to container scaling alone. Could we generate evenly distributed positions
across the full domain for each container count, then repeat them as needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
