alamb commented on PR #23682: URL: https://github.com/apache/datafusion/pull/23682#issuecomment-5527445585
I haven't reviewed this PR in detail -- basically my concern with this type of optimization would always be the tradeoff between additional complexity / code size and applicability of the optimization. So typically we would look for a benchmark that is realistic (aka is plausible it represents some real workload) that improves relative to the complexity added. How do we think this PR compares on these metrics? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
