alamb commented on PR #11977: URL: https://github.com/apache/datafusion/pull/11977#issuecomment-2296951593
What is the current status of this PR? I am a little confused @viirya seems to suggest this would be a good change, but @jayzhan211 points out this change would mean anyone who built `PhysicalExpr`s without a corresponding `Expr` would have to create their own schema names > We should get physical name from Physical expression not from Expr. If we are building the expr from builder, there is no Expr that you could get the name from. So I guess my question is "if we merge this PR would it mess up comet (or other users of only physical exprs)?" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
