adibmbrk opened a new pull request, #5606: URL: https://github.com/apache/datafusion-comet/pull/5606
## Which issue does this PR close? Closes #5585. ## Rationale for this change `CometStringTranslate` reported itself as `Incompatible` unconditionally, forcing whole projections to fall back to Spark unless `spark.comet.expression.StringTranslate.allowIncompatible=true` was set. Comparable string functions (`CometInitCap`, `CometStringReplace`) instead run natively by default through the JVM codegen dispatcher and treat their semantic differences as an opt-in caveat. ## What changes are included in this PR? - `CometStringTranslate` mixes in `NativeOptInAvailable`: default is `Compatible` and routes through the codegen dispatcher (Spark-compatible); the incompatible native DataFusion path is opt-in via `allowIncompatible`. - Docs: `translate` updated from `Native` to `Hybrid`. ## How are these changes tested? Ran the affected suites against Spark 4.1 (`-Dtest=none -Dsuites=...`): - `CometFallbackInvarianceSuite` — `pass=25 fail=0 excused=0 vacuous=0` (translate is now a real native-vs-fallback parity pass rather than the previous SKIPPED-VACUOUS case). - `CometStringExpressionSuite` — 39 tests succeeded, 0 failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
