milenkovicm commented on code in PR #2387:
URL:
https://github.com/apache/datafusion-ballista/pull/2387#discussion_r3890265471
##########
ballista/core/src/config.rs:
##########
@@ -746,8 +752,8 @@ impl BallistaConfig {
/// Returns the target post-coalesce partition byte size in bytes
/// (Spark's `advisoryPartitionSizeInBytes`).
- pub fn coalesce_target_partition_bytes(&self) -> u64 {
- self.get_usize_setting(BALLISTA_COALESCE_TARGET_PARTITION_BYTES) as u64
+ pub fn coalesce_target_partition_bytes(&self) -> usize {
Review Comment:
yes, this was deliberate, as all other public methods exposed in
`SessionConfigExt` return `usize` instead of `u64`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
