goldmedal commented on code in PR #11035:
URL: https://github.com/apache/datafusion/pull/11035#discussion_r1721030391


##########
datafusion-cli/src/catalog.rs:
##########
@@ -115,13 +114,14 @@ impl CatalogProvider for DynamicFileCatalogProvider {
     }
 }
 
-/// Wraps another schema provider
-struct DynamicFileSchemaProvider {
+/// Wraps another schema provider. [DynamicObjectStoreSchemaProvider] is 
responsible for registering the required

Review Comment:
   Maybe we can provide something like installing extensions for 
datafusion-cli? There're some similar use cases in DuckDB 
[httpfs](https://duckdb.org/docs/extensions/httpfs/overview). Before scanning 
the remote file, user should load the corresponding extensions (BTW, they also 
do some autolaoding for specific extensions, e.g. httpfs)
   
   I think it maybe related to the `dfdb` purpose 
https://github.com/apache/datafusion/issues/11979 . It's a nice way to provide 
more feature for the user.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to