github-actions[bot] commented on PR #24628: URL: https://github.com/apache/datafusion/pull/24628#issuecomment-5399226694
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-physical-expr-common v55.0.0 (current) Built [ 25.417s] (current) Parsing datafusion-physical-expr-common v55.0.0 (current) Parsed [ 0.023s] (current) Building datafusion-physical-expr-common v55.0.0 (baseline) Built [ 24.691s] (baseline) Parsing datafusion-physical-expr-common v55.0.0 (baseline) Parsed [ 0.024s] (baseline) Checking datafusion-physical-expr-common v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.317s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure trait_now_doc_hidden: pub trait is now #[doc(hidden)] --- Description: A pub trait is now #[doc(hidden)], removing it from the crate's public API. ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_now_doc_hidden.ron Failed in: trait PhysicalExprDecode in file /home/runner/work/datafusion/datafusion/datafusion/physical-expr-common/src/physical_expr.rs:1069 trait PhysicalExprEncode in file /home/runner/work/datafusion/datafusion/datafusion/physical-expr-common/src/physical_expr.rs:662 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 51.694s] datafusion-physical-expr-common Building datafusion-physical-plan v55.0.0 (current) Built [ 37.546s] (current) Parsing datafusion-physical-plan v55.0.0 (current) Parsed [ 0.158s] (current) Building datafusion-physical-plan v55.0.0 (baseline) Built [ 37.585s] (baseline) Parsing datafusion-physical-plan v55.0.0 (baseline) Parsed [ 0.159s] (baseline) Checking datafusion-physical-plan v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 1.007s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 77.854s] datafusion-physical-plan Building datafusion-proto v55.0.0 (current) Built [ 54.683s] (current) Parsing datafusion-proto v55.0.0 (current) Parsed [ 0.021s] (current) Building datafusion-proto v55.0.0 (baseline) Built [ 55.171s] (baseline) Parsing datafusion-proto v55.0.0 (baseline) Parsed [ 0.020s] (baseline) Checking datafusion-proto v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.171s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 111.532s] datafusion-proto Building datafusion-proto-models v55.0.0 (current) Built [ 25.050s] (current) Parsing datafusion-proto-models v55.0.0 (current) Parsed [ 0.136s] (current) Building datafusion-proto-models v55.0.0 (baseline) Built [ 24.840s] (baseline) Parsing datafusion-proto-models v55.0.0 (baseline) Parsed [ 0.138s] (baseline) Checking datafusion-proto-models v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 2.534s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron Failed in: field PhysicalExtensionExprNode.expr_name in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1869 field PhysicalExtensionExprNode.expr_name in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1869 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 54.190s] datafusion-proto-models ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
