SubhamSinghal commented on code in PR #24378:
URL: https://github.com/apache/datafusion/pull/24378#discussion_r3841181732
##########
datafusion/physical-plan/src/joins/piecewise_merge_join/exec.rs:
##########
@@ -677,6 +677,114 @@ impl ExecutionPlan for PiecewiseMergeJoinExec {
fn metrics(&self) -> Option<MetricsSet> {
Some(self.metrics.clone_inner())
}
+
+ #[cfg(feature = "proto")]
+ fn try_to_proto(
+ &self,
+ ctx: &crate::proto::ExecutionPlanEncodeCtx<'_>,
+ ) -> Result<Option<datafusion_proto_models::protobuf::PhysicalPlanNode>> {
+ use datafusion_proto_models::protobuf;
+
+ let buffered = ctx.encode_child(self.buffered())?;
+ let streamed = ctx.encode_child(self.streamed())?;
+ let on_buffered = ctx.encode_expr(&self.on.0)?;
+ let on_streamed = ctx.encode_expr(&self.on.1)?;
+ let join_type =
crate::joins::proto::join_type_to_proto(self.join_type());
Review Comment:
addressed in 3f9f4970dcadd5557a8ef971473e8a054cc28aca
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
