avantgardnerio commented on code in PR #2348:
URL:
https://github.com/apache/datafusion-ballista/pull/2348#discussion_r3833662998
##########
ballista/core/src/serde/mod.rs:
##########
@@ -190,49 +185,12 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> BallistaCodec<T,
#[derive(Debug)]
pub struct BallistaLogicalExtensionCodec {
default_codec: Arc<dyn LogicalExtensionCodec>,
- file_format_codecs: Vec<Arc<dyn LogicalExtensionCodec>>,
-}
-
-impl BallistaLogicalExtensionCodec {
- /// looks for a codec which can operate on this node
- /// returns a position of codec in the list and result.
- ///
- /// position is important with encoding process
- /// as position of used codecs is needed
- /// so the same codec can be used for decoding
- fn try_any<R>(
- &self,
- mut f: impl FnMut(&dyn LogicalExtensionCodec) -> Result<R>,
- ) -> Result<(u32, R)> {
- let mut last_err = None;
Review Comment:
I was not sure what convention we wanted to support here. I'm not sure if
folks are tracking ballista/main in their own projects. It seemed like
monotonic bumps couldn't hurt. @phillipleblanc ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
