alamb opened a new pull request, #24544: URL: https://github.com/apache/datafusion/pull/24544
## Which issue does this PR close? - N/A, small follow on cleanup from the deprecation sweep in #24535, #24540 and #24542 ## Rationale for this change The [API health policy deprecation guidelines] say: > Mark the API as deprecated using `#[deprecated]` and specify the exact DataFusion version in which it was deprecated Five `#[deprecated]` attributes on `main` have no `since`, so there is no way to tell when the "6 major versions or 6 months" removal clock started for them. That makes them invisible to the periodic sweeps that remove APIs which are past the policy. [API health policy deprecation guidelines]: https://datafusion.apache.org/contributor-guide/api-health.html#deprecation-guidelines ## What changes are included in this PR? Adds `since` to each of the five. The version is the release that first contained the commit which added the attribute, determined with `git tag --contains`: | Item | `since` | Deprecated in | | --- | --- | --- | | `create_aggregate_expr_with_name_and_maybe_filter` | 54.0.0 | #21739 | | `create_aggregate_expr_and_maybe_filter` | 54.0.0 | #21739 | | `datafusion_functions::string::overlay` re-export | 47.0.0 | #15217 | | `make_filter` | 55.0.0 | #21668 | | `spill_pool::channel` | 55.0.0 | #23522 | `make_filter` had a bare `#[deprecated]` with no replacement guidance, so this also adds the `note` the policy asks for (`Use `Filter::try_new` instead`), matching what its doc comment already said. ## Are these changes tested? No new tests. `since` is metadata on an existing attribute with no runtime behavior, and the existing `#[expect(deprecated)]` / `#[allow(deprecated)]` call sites are checked by `cargo clippy --all-targets --all-features -- -D warnings`, which passes. ## Are there any user-facing changes? No APIs are added, removed, or changed. Deprecation warnings for these five items now report the version, for example: ``` warning: use of deprecated function `make_filter`: Use `Filter::try_new` instead ``` Once merged, `overlay` (47.0.0) is immediately past the policy and can be picked up by the next removal sweep; the other four become eligible in 60.0.0 and 61.0.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
