github-actions[bot] commented on PR #24528: URL: https://github.com/apache/datafusion/pull/24528#issuecomment-5359851536
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v55.0.0 (current) Built [ 59.951s] (current) Parsing datafusion v55.0.0 (current) Parsed [ 0.034s] (current) Building datafusion v55.0.0 (baseline) Built [ 58.261s] (baseline) Parsing datafusion v55.0.0 (baseline) Parsed [ 0.033s] (baseline) Checking datafusion v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.635s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 120.562s] datafusion Building datafusion-datasource v55.0.0 (current) Built [ 42.173s] (current) Parsing datafusion-datasource v55.0.0 (current) Parsed [ 0.031s] (current) Building datafusion-datasource v55.0.0 (baseline) Built [ 42.065s] (baseline) Parsing datafusion-datasource v55.0.0 (baseline) Parsed [ 0.031s] (baseline) Checking datafusion-datasource v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.254s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 85.658s] datafusion-datasource Building datafusion-datasource-parquet v55.0.0 (current) Built [ 47.837s] (current) Parsing datafusion-datasource-parquet v55.0.0 (current) Parsed [ 0.032s] (current) Building datafusion-datasource-parquet v55.0.0 (baseline) Built [ 47.783s] (baseline) Parsing datafusion-datasource-parquet v55.0.0 (baseline) Parsed [ 0.033s] (baseline) Checking datafusion-datasource-parquet v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.165s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 96.886s] datafusion-datasource-parquet Building datafusion-physical-optimizer v55.0.0 (current) Built [ 39.441s] (current) Parsing datafusion-physical-optimizer v55.0.0 (current) Parsed [ 0.021s] (current) Building datafusion-physical-optimizer v55.0.0 (baseline) Built [ 40.382s] (baseline) Parsing datafusion-physical-optimizer v55.0.0 (baseline) Parsed [ 0.022s] (baseline) Checking datafusion-physical-optimizer v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.113s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 80.937s] datafusion-physical-optimizer Building datafusion-physical-plan v55.0.0 (current) Built [ 37.796s] (current) Parsing datafusion-physical-plan v55.0.0 (current) Parsed [ 0.149s] (current) Building datafusion-physical-plan v55.0.0 (baseline) Built [ 37.772s] (baseline) Parsing datafusion-physical-plan v55.0.0 (baseline) Parsed [ 0.149s] (baseline) Checking datafusion-physical-plan v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.685s] 223 checks: 221 pass, 2 fail, 0 warn, 31 skip --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_variant_added.ron Failed in: variant PushedDown:Exact in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/filter_pushdown.rs:146 variant PushedDown:Inexact in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/filter_pushdown.rs:150 variant PushedDown:Unsupported in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/filter_pushdown.rs:152 --- failure enum_variant_missing: pub enum variant removed or renamed --- Description: A publicly-visible enum has at least one variant that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_variant_missing.ron Failed in: variant PushedDown::Yes, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/2dedd5ae688eb3e8fff5cea485f507d572c5bedc/datafusion/physical-plan/src/filter_pushdown.rs:128 variant PushedDown::No, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/2dedd5ae688eb3e8fff5cea485f507d572c5bedc/datafusion/physical-plan/src/filter_pushdown.rs:130 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 77.643s] datafusion-physical-plan ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
