vbarua commented on code in PR #24346:
URL: https://github.com/apache/datafusion/pull/24346#discussion_r3823060507
##########
datafusion/substrait/src/logical_plan/consumer/rel/read_rel.rs:
##########
@@ -114,29 +113,24 @@ pub async fn from_read_rel(
.await
}
Some(ReadType::VirtualTable(vt)) => {
- if vt.values.is_empty() && vt.expressions.is_empty() {
+ if vt.expressions.is_empty() {
return Ok(LogicalPlan::EmptyRelation(EmptyRelation {
produce_one_row: false,
schema: DFSchemaRef::new(substrait_schema),
}));
}
- // Check for produce_one_row pattern in both old (values) and new
(expressions) formats.
+ // Check for produce_one_row pattern in the new expressions format.
Review Comment:
minor: it's not particularly useful, IMO, to indicate that this is the "new"
expression format here.
```suggestion
// Check for produce_one_row pattern
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
