sunchao commented on code in PR #5377: URL: https://github.com/apache/datafusion-comet/pull/5377#discussion_r3810324627
########## spark/src/test/resources/sql-tests/expressions/misc/variant.sql: ########## @@ -22,14 +22,26 @@ -- MinSparkVersion: 4.0 statement -CREATE TABLE test_variant(id INT, v VARIANT) USING parquet +CREATE TABLE test_variant(id INT, v VARIANT, tail STRING) USING parquet Review Comment: Added explicit `ARRAY<VARIANT>` and `MAP<STRING, VARIANT>` coverage for both Parquet and Iceberg. The tests verify that native scans remain enabled when the collection columns are unprojected and fall back to Spark when either collection is projected. They also cover SQL-null elements and map values, Variant JSON null, and null collection roots. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
