alamb commented on code in PR #24471: URL: https://github.com/apache/datafusion/pull/24471#discussion_r3809187249
########## docs/source/user-guide/sql/data_types.md: ########## @@ -107,32 +114,46 @@ The maximum supported precision for `DECIMAL` types is 76. ## Boolean Types -| SQL DataType | Arrow DataType | -| ------------ | :------------- | -| `BOOLEAN` | `Boolean` | +| SQL DataType | Arrow DataType | +| ------------------- | :------------- | +| `BOOLEAN` or `BOOL` | `Boolean` | ## Binary Types | SQL DataType | Arrow DataType | | ------------ | :------------- | | `BYTEA` | `Binary` | +| `BLOB` | `Binary` | +| `BINARY` | `Binary` | +| `VARBINARY` | `Binary` | +| `BYTES` | `Binary` | Review Comment: Are these really supported I tried and I got a not supported error: ```sql DataFusion CLI v55.0.0 > create table foo (x BLOB); This feature is not implemented: Unsupported SQL type BLOB > create table foo (x BINARY); This feature is not implemented: Unsupported SQL type BINARY > create table foo (x VARBINARY); This feature is not implemented: Unsupported SQL type VARBINARY > create table foo (x BYTES); This feature is not implemented: Unsupported SQL type BYTES ``` ########## docs/source/user-guide/sql/data_types.md: ########## @@ -67,32 +67,39 @@ select arrow_cast(now(), 'Timestamp(Second, None)') as "now()"; ## Character Types -| SQL DataType | Arrow DataType | -| ------------ | -------------- | -| `CHAR` | `Utf8View` | -| `VARCHAR` | `Utf8View` | -| `TEXT` | `Utf8View` | -| `STRING` | `Utf8View` | +| SQL DataType | Arrow DataType | +| ------------------- | -------------- | +| `CHAR` | `Utf8View` | +| `VARCHAR` | `Utf8View` | +| `TEXT` | `Utf8View` | +| `STRING` | `Utf8View` | +| `CHARACTER VARYING` | `Utf8View` | +| `CHAR VARYING` | `Utf8View` | +| `NVARCHAR` | `Utf8View` | By default, string types are mapped to `Utf8View`. This can be configured using the `datafusion.sql_parser.map_string_types_to_utf8view` setting. When set to `false`, string types are mapped to `Utf8` instead. +Note that `CHAR`, `VARCHAR`, `STRING`, `CHARACTER VARYING`, `CHAR VARYING`, and `NVARCHAR` can Review Comment: 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
