schenksj commented on PR #4952:
URL:
https://github.com/apache/datafusion-comet/pull/4952#issuecomment-5333554576
Heads-up before you re-review: the branch head moved after my comment above.
My previous comment described the item-5 change
(`spark.comet.scan.contrib.detectConflicts.enabled`
plus the conflict-detecting path in `CometScanContrib`) as being in this PR,
but I had only
committed it locally — it wasn't pushed until just now. The head is
`9ab285fc8`; anything you looked
at at `c56e486ba` was missing that change. Sorry for the noise.
`9ab285fc8` is the complete set the comment describes:
- item 2 — `spark.comet.scan.deltaNative.enabled` defaults to `false`,
`dataFileConcurrencyLimit`
doc reconciled, `cdf.maxPartitions` removed from A.2 (it moves to A.5)
- item 4 — `CometConfigProvider` SPI + `GenerateDocs` hook
- item 5 — `detectConflicts` config + the warn-on-multiple-claims path, with
two tests
CI is re-running as a result.
Separately, on your item 1 (CI not compiling the Delta Scala until A.6a):
that one is **not** in this
PR. It goes in A.3a, which extends `dev/verify-contrib-delta-gate.sh` with a
`-Pcontrib-delta
test-compile` plus an anti-vacuous check that the build actually produced
contrib classes. Putting it
in A.3a rather than here keeps this PR to what you already reviewed, and
A.3a still lands before the
first part with substantial Delta Scala (A.4a), so nothing is left unguarded
in between. Full gate
passes 12/12 with the new checks, and the step is red-proven — injecting a
type error into the
contrib fails it.
---
🤖 This reply was drafted with [Claude Code](https://claude.com/claude-code).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
