peterxcli commented on PR #5046: URL: https://github.com/apache/datafusion-comet/pull/5046#issuecomment-5332230161
@mbutrovich thanks for the review, added `require` to assert the `maxRecordsPerBatch` for `RowArrowReader` is always greater than zero. and because when it calls `ArrowWriter.create(root, capacity = maxRecordsPerBatch)` which require `capacity` to be `Int`, so I change `maxRecordsPerBatch` to `Int`, too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
