comphead commented on PR #4582: URL: https://github.com/apache/datafusion-comet/pull/4582#issuecomment-5330599818
I'm going to test this approach soon one thing, if I understand correctly this approach would help with overall accounting difference between DF memory pools and actual resident memory usage. However it wouldn't get us closer to identify threshold for spilling. Currently it's hard(if even possible) to do fine grained analysis and identify which object/layer allocated resources through this approach. So spilling IMO still relies on DF memory pools unless @avantgardnerio as usual have an elegant memory solution :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
