DevShiba commented on PR #24218: URL: https://github.com/apache/datafusion/pull/24218#issuecomment-5327272963
@kosiew Done - merged upstream/main in and resolved the one real conflict in `parquet_nested_schema_pruning.slt`. Main had landed a schema-pruning improvement in the meantime (unions the read leaves for disjoint cast targets instead of falling back to a full-column read), which changed `bytes_scanned` for one of the queries in that file (219 → 148 bytes) and added two new test cases. Kept main's new queries/values and applied this PR's byte-unit formatting on top of them. Also picked up the 3 CI failures that showed up on the first run (`cargo test (amd64)`, `cargo test hash collisions (amd64)`, `cargo test 'extended_tests' (amd64)`) - those were the same conflict, since the branch was 114 commits behind and hadn't been tested against the current `bytes_scanned` value from main's pruning change. Re-verified after merging: full `cargo check --workspace --all-targets`, `cargo fmt --check`, the two directly-touched sqllogictest files, and the metrics/FFI unit tests all pass clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
