Dandandan commented on code in PR #24326:
URL: https://github.com/apache/datafusion/pull/24326#discussion_r3776694580
##########
datafusion/session/src/table.rs:
##########
@@ -338,46 +340,84 @@ pub trait TableProvider: Any + Debug + Sync + Send {
/// streams of `RecordBatch`es as files to an ObjectStore.
///
/// [`DataSinkExec`]:
https://docs.rs/datafusion-datasource/latest/datafusion_datasource/sink/struct.DataSinkExec.html
- async fn insert_into(
- &self,
- _state: &dyn Session,
+ // Compile-time optimization: these defaults are written as the desugaring
of
+ // `async fn` so they return a ready future instead of a coroutine
capturing
+ // `Expr`, whose `Send` proof pulls in the whole `LogicalPlan` graph and is
+ // re-proved per method (~2x faster to compile this crate).
+ fn insert_into<'life0, 'life1, 'async_trait>(
Review Comment:
(Above is Claude)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
