pingzh opened a new pull request, #5344:
URL: https://github.com/apache/datafusion-comet/pull/5344

   ## Which issue does this PR close?
   
   No issue filed.
   
   ## Rationale for this change
   
   The `core-amd64-libs` and `core-arm64-libs` targets hardcode `cargo build -j 
2`, limiting compilation to two concurrent jobs regardless of available CPU 
resources.
   
   This also overrides Cargo's standard `CARGO_BUILD_JOBS` environment variable 
and `build.jobs` configuration, preventing users from controlling parallelism 
through existing Cargo mechanisms.
   
   Removing the hardcoded limit lets Cargo automatically determine the 
appropriate level of parallelism while preserving the ability to configure it 
explicitly:
   
   ```bash
   CARGO_BUILD_JOBS=2 make core-amd64-libs
   ```
   
   ## What changes are included in this PR?
   
   Remove `-j 2` from all four Cargo invocations in `core-amd64-libs` and 
`core-arm64-libs`, including optional macOS cross-compilation builds.
   
   ## How are these changes tested?
   
   Verified the generated commands for both architectures:
   
   ```bash
   make -n core-amd64-libs core-arm64-libs
   make -n HAS_OSXCROSS=1 core-amd64-libs core-arm64-libs
   ```
   
   Also verified that `CARGO_BUILD_JOBS=7` is passed through to all four Cargo 
invocations using mocked `cargo` and `rustup` binaries.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to