kosiew commented on code in PR #23188: URL: https://github.com/apache/datafusion/pull/23188#discussion_r3764349991
########## docs/source/library-user-guide/upgrading/55.0.0.md: ########## @@ -1143,6 +1143,37 @@ Previously, this query returned `2.0`, the distance between `[1, 2]` and `[1, 4]`. It now returns a planning error stating that `array_distance` only supports one-dimensional arrays. +### `ExprType` gained a `SqlSimilarToPattern` variant + +`SIMILAR TO` with a non-literal (column- or expression-based) pattern is now +represented by a new `SqlSimilarToPattern` physical expression, so it can be +serialized. The generated `ExprType` enum on `PhysicalExprNode` gained a +matching `SqlSimilarToPattern` variant (tag 24). Review Comment: Small documentation fix: this says `SqlSimilarToPattern` uses protobuf tag 24, but the field added in `datafusion.proto` uses tag 27. Tags 24 through 26 are already occupied. Could we update this to say tag 27? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
