Xuanwo commented on PR #23828: URL: https://github.com/apache/datafusion/pull/23828#issuecomment-5252463782
Thanks for the detailed review — this was very helpful. I added result-based coverage for no equality keys, both `>=` and `<`, and complex equality/match expressions. I also aligned projection with the existing join convention, simplified the metrics and tests, and documented the state-machine loop. I left the `PendingRows` redesign and right-cursor fast-forwarding for a benchmark-backed follow-up after the end-to-end SQL integration, as suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
