peterxcli commented on PR #5174: URL: https://github.com/apache/datafusion-comet/pull/5174#issuecomment-5227446892
@andygrove thanks for another round of review, addressed all of your review. please take another look. TIA! > **An explicit null default could take the fast path too** Explicit-null defaults now use the Arrow `take` fast path. Added OOB/null regression coverage and explicit-null benchmarks. > **Build the indices with `UInt64Builder` rather than `Vec<Option<u64>>`** Replaced the temporary vector and conversion with direct builder writes. Isolated performance varied from +14.9% to −17.0%, so there is no stable builder-only claim. > **The two row loops have to stay in sync** Added shared `Gather`/`Null`/`Default` row resolution. Added direct no-default ANSI tests for `InvalidElementAtIndex` and `InvalidArrayIndex`. > **SQL test coverage for complex element types** Added nested-array and struct-array cases covering valid extraction, null lists, and null ordinals. > **The benchmark lists have no nulls** Added disjoint 25% null-list and 25% null-ordinal workloads. result is updated in PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
