shuvamk commented on PR #2425: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2425#issuecomment-5225766112
Thanks — all four addressed in the follow-up commit. `DIV` and `|>` are both documented for Databricks SQL, so I added them: `supports_pipe_operator`, and `parse_infix` delegating to Spark, which handles `DIV` and nothing else. On delegating the flags: I converted the ones Spark and Databricks share, but left `supports_numeric_prefix`, `supports_table_versioning` and `supports_optimize_table` as they were — Spark doesn't override those, so delegating would take them from `true` to the trait default `false` and stop `SELECT 59901_user`, `VERSION AS OF` and `OPTIMIZE` from parsing on Databricks. Happy to convert the remaining shared ones too if you'd like the whole block consistent. The cross-dialect asserts moved to `tests/sqlparser_common.rs` so Databricks is covered, with the flag-off negatives alongside them. `MAP<K, V>` needed a per-dialect loop rather than one `is_err()` — the ungated dialects split into two different error messages. Title and description updated for the added scope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
