comphead commented on code in PR #5185:
URL: https://github.com/apache/datafusion-comet/pull/5185#discussion_r3693851681
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -177,10 +177,25 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
castTest(generateBools(), DataTypes.DoubleType)
}
- test("cast BooleanType to DecimalType(10,2)") {
+ // Boolean -> Decimal has no native path and is routed through the JVM
codegen dispatcher, so
+ // `CometCast.isSupported` reports it as unsupported and the
matrix-consistency test above
+ // requires this one to be ignored. Execution coverage, including the ANSI
overflow edge cases,
+ // lives in `sql-tests/expressions/cast/cast_boolean_to_decimal{,_ansi}.sql`.
+ ignore("cast BooleanType to DecimalType(10,2)") {
Review Comment:
do we need this ignored test? are we planning to switch it back after future
changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
