parthchandra commented on code in PR #5180:
URL: https://github.com/apache/datafusion-comet/pull/5180#discussion_r3693654714
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometIcebergNativeScanExec.scala:
##########
@@ -220,11 +220,15 @@ case class CometIcebergNativeScanExec(
override def doExecuteColumnar(): RDD[ColumnarBatch] = {
val nativeMetrics = CometMetricNode.fromCometPlan(this)
val serializedPlan = CometExec.serializeNativePlan(nativeOp)
+ // Key by the same (metadata_location, scan_hash_code) pair
PlanDataInjector.injectPlanData
+ // looks up via IcebergPlanDataInjector.getKey (see the scan_hash_code
field comment in
+ // operator.proto for why metadata_location alone cannot identify a scan).
+ val injectorKey =
IcebergPlanDataInjector.getKey(nativeOp).getOrElse(metadataLocation)
Review Comment:
nit: `getKey` on an Iceberg op always returns` Some`, so
`.getOrElse(metadataLocation)` never actually fires. probably safe to have it
though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
