alamb commented on code in PR #24036:
URL: https://github.com/apache/datafusion/pull/24036#discussion_r3693320320
##########
datafusion/datasource-parquet/src/reader.rs:
##########
@@ -293,7 +287,7 @@ impl AsyncFileReader for CachedParquetFileReader {
options: Option<&'a ArrowReaderOptions>,
) -> BoxFuture<'a, parquet::errors::Result<Arc<ParquetMetaData>>> {
let object_meta = self.partitioned_file.object_meta.clone();
- let metadata_cache = Arc::clone(&self.metadata_cache);
+ let metadata_cache = self.metadata_cache.clone();
Review Comment:
this is now Option<Arc<..>> so it needs a clone (rather than being able to
call Arc::clone directly
##########
datafusion/datasource-parquet/src/reader.rs:
##########
@@ -86,62 +86,6 @@ impl DefaultParquetFileReaderFactory {
}
}
-/// Implements [`AsyncFileReader`] for a parquet file in object storage.
Review Comment:
this was all duplicated with CachedParquetFilerReader and I have unified the
two
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
