gabotechs commented on PR #23842: URL: https://github.com/apache/datafusion/pull/23842#issuecomment-5140532048
> I don't know why I can't respond on the thread for this comment, but my thought was to first expose what we need for the FFI_QueryPlanner right now and keep https://github.com/apache/datafusion/issues/23678 open for follow on work. Did a quick search in open-source projects that might have issues with this switch from `SessionState` to `dyn Session`, and the only thing I found is this: https://github.com/GreptimeTeam/greptimedb/blob/c3d8c976a22ba145e88e2e6602accf78d1ac7a37/src/query/src/dist_plan/planner.rs#L421-L428 And the `SessionState` there comes from: https://github.com/GreptimeTeam/greptimedb/blob/c3d8c976a22ba145e88e2e6602accf78d1ac7a37/src/query/src/dist_plan/planner.rs#L160-L180 I think they should be covered with the added `Session::optimize` method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
