Rich-T-kid commented on PR #23187: URL: https://github.com/apache/datafusion/pull/23187#issuecomment-5139235568
@kumarUjjawal commit https://github.com/apache/datafusion/pull/23187/commits/c98c47f20831c0314876f2f3bb288efebd52d693: - Fix `take_n` null-slot ordering: After compaction, null is always placed at the last slot so `check_key_overflow` can correctly exclude it from the key count, previously `take_n` could reorder null to a mid-slot position, causing a valid Int8 dictionary to panic at capacity. also added a test asserting this behavior - Compact emitted values in `take_n`: The emitted dictionary now only contains values referenced by the emitted groups (via `take()`) rather than all distinct values ever seen, eliminating the quadratic serialization cost on partial emits. is there anything else? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
