2010YOUY01 commented on code in PR #24012: URL: https://github.com/apache/datafusion/pull/24012#discussion_r3687724677
########## datafusion/physical-plan/src/aggregates/ordered_partial_stream.rs: ########## Review Comment: I think we could even further move the surrounding setup/cleanup code into this function similarly, then the entry point will only have ``` self.handle_reading_input(emitter) self.handle_draining_final(emitter) ``` Each is representing a execution state, this organization I think map really close to the idea behind it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
