2010YOUY01 commented on PR #23970: URL: https://github.com/apache/datafusion/pull/23970#issuecomment-5129274293
> I wonder if these tests would be better in `string_query.slt.part` instead? Thank you for the review! The existing string slt structure is - shared query file `string_query.slt.part` - Different drivers for different physical string types (`string.slt` and `string_view.slt` set up logically equivalent dataset table, but they have different physical representation for string) So I think `string_query.slt.part` is not flexible enough to add test cases targeting individual functions, so I created a new test file `string_extra.slt` for those additional test cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
