iffyio commented on code in PR #2367:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2367#discussion_r3681574756
##########
tests/sqlparser_common.rs:
##########
@@ -3883,6 +3883,96 @@ fn parse_negative_value() {
);
}
+#[test]
+fn parse_create_sequence_clause_order_independent() {
Review Comment:
I think the tests can be simplified by
- using the canonical input and calling verified_stmt instead (no point in
testing that `integer` input comes out as `INTEGER`)
- Dropping the AST assertions, the changes don't introduce any AST changes
so I don't think the AST check provides much coverage to warrant it
- Merge the tests scenarios into the same function, better yet we can inline
them into an existing `CREATE SEQUENCE` if present
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
