qzyu999 commented on PR #1625: URL: https://github.com/apache/datafusion-python/pull/1625#issuecomment-5125443928
Hi @timsaucer, thanks for merging main in and getting CI running. I've pushed a fix for the 3 test failures, the issue was that `file://` URLs have an empty `netloc` (e.g. `file:///tmp/foo.parquet`), so `_register_object_store_for_path` was rejecting them. I've updated it to allow empty `netloc` for the `file://` scheme while still requiring a host/bucket for `s3://`, `gs://`, etc. Also added `# doctest: +SKIP` to the `register_parquet` example and switched the end-to-end tests to use `Path.as_uri()` for cross-platform portability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
